Repository navigation
perf(viewer): share one mtime-keyed cache for the trends CSV and dir listing - #555
Open
omkargaikwad23 wants to merge 1 commit into
Open
omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
omkargaikwad23
marked this pull request as ready for review
August 9, 2026 18:43
omkargaikwad23
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
August 9, 2026 18:43
omkargaikwad23
force-pushed
the
perf/chart-payload
branch
from
August 20, 2026 08:12
9f84c1f to
8d106d5
Compare
omkargaikwad23
force-pushed
the
perf/shared-trends-caches
branch
from
August 20, 2026 08:12
fef7b53 to
c2dc17f
Compare
omkargaikwad23
force-pushed
the
perf/chart-payload
branch
from
August 20, 2026 08:23
8d106d5 to
7174291
Compare
omkargaikwad23
force-pushed
the
perf/shared-trends-caches
branch
from
August 20, 2026 08:23
c2dc17f to
6e43752
Compare
omkargaikwad23
force-pushed
the
perf/chart-payload
branch
from
September 14, 2026 05:50
7174291 to
7a1dd96
Compare
omkargaikwad23
force-pushed
the
perf/shared-trends-caches
branch
from
November 10, 2026 17:25
6e43752 to
aeac5e4
Compare
omkargaikwad23
force-pushed
the
perf/chart-payload
branch
from
November 10, 2026 17:25
7a1dd96 to
98b7bb3
Compare
| return None | ||
|
|
||
| logging.info(f"Loaded {len(df)} rows from trends cache.") | ||
| _TRENDS_DF_CACHE = (mtime, df) |
omkargaikwad23
force-pushed
the
perf/shared-trends-caches
branch
from
November 11, 2026 05:46
aeac5e4 to
8c9122e
Compare
omkargaikwad23
force-pushed
the
perf/chart-payload
branch
from
November 11, 2026 05:46
98b7bb3 to
85676da
Compare
omkargaikwad23
changed the base branch from
perf/chart-payload
to
perf/list-summaries-cache
November 11, 2026 05:46
…listing trends_cache.csv was reparsed on every render by the Status tab, the Charts tab and the run detail view, and the results directory was relisted three times per page load. On the GCS FUSE mount each listing costs one stat per run directory, so both scaled with the number of runs and ran on interactions that needed neither. Add load_trends_df and list_run_dirs, keyed on mtime, and route every caller through them. load_summaries now builds on load_trends_df so the CSV is parsed once rather than twice. The frame is now shared, so the Charts filter chain uses assign() rather than an in-place column write, which would otherwise have welded product_dataset onto the cached object.
omkargaikwad23
force-pushed
the
perf/shared-trends-caches
branch
from
November 11, 2026 05:54
8c9122e to
d0edc26
Compare
omkargaikwad23
force-pushed
the
perf/list-summaries-cache
branch
from
November 11, 2026 05:54
efa7bde to
a880916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trends_cache.csvwas reparsed on every render by the Status tab, the Charts tab and the List view. On the GCS FUSE mount each parse reads the full file, so the cost scaled with the number of runs and ran on interactions that needed no data.Add
load_trends_df, keyed on the file mtime, and route the Status tab, the Charts tab andload_summariesthrough it. The CSV is parsed once per change rather than once per render.load_trends_dfreads withusecols=lambda c: c != 'ai_summary'and appliesprecompute_trends.filter_valid_cache_rows, the same as the readers it replaces. The run detail view keeps its own narrow read because it needsai_summaryfor one run.The frame is shared, so the Charts filter chain uses
assign()rather than an in-place column write.Rebased on main 2026-11-10. The original
list_run_dirsis dropped: main now hasrun_index.list_run_directories, which caches the directory listing with a TTL and an explicitinvalidate().Stack created with GitHub Stacks CLI • Give Feedback 💬