Repository navigation
Remove gcs validation flag - #162
Merged
Merged
Conversation
nauh
reviewed
Mar 31, 2022
| "--enable_experimental_dataplex_gcs_validation", | ||
| help="If True, allows validating Dataplex GCS resources using " | ||
| "BigQuery External Tables", | ||
| help="This flag is set to True by default, it allows validating Dataplex GCS resources using " |
Collaborator
There was a problem hiding this comment.
nit: "This flag has no effect and is now deprecated. GCS resource validation via BigQuery External Tables is supported regardless of the value of this flag. Please remove it from your script."
Collaborator
There was a problem hiding this comment.
Is it only for GCS resource attached to Dataplex, or any GCS resource behind BigQuery external table?
nauh
reviewed
Mar 31, 2022
| is_flag=True, | ||
| default=False, | ||
| default=True, | ||
| hidden=True, |
Collaborator
There was a problem hiding this comment.
We don't need to hide it, given that the description is updated (so user can actually see the description and hopefully remove flags from their script)
nauh
reviewed
Mar 31, 2022
| summary_to_stdout: bool = False, | ||
| enable_experimental_bigquery_entity_uris: bool = False, | ||
| enable_experimental_dataplex_gcs_validation: bool = False, | ||
| enable_experimental_dataplex_gcs_validation: bool = True, |
nauh
previously approved these changes
Apr 4, 2022
…ata-quality into remove-gcs-validation-flag � Conflicts: � clouddq/classes/dq_configs_cache.py � clouddq/integration/dataplex/clouddq_dataplex.py � clouddq/main.py � tests/integration/test_dataplex_integration_performance.py � tests/integration/test_dataplex_task.py
thinhha
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.