Sitelet https://github.com/Glimpse/Glimpse.Prototype/pull/92
Skip to content
This repository was archived by the owner on Jan 15, 2021. It is now read-only.

Appending html to PostContent rather than set - #92

Merged
Nik Molnar (nikmd23) merged 1 commit into
Glimpse:devfrom
damienpontifex:post-content-append
Nov 30, 2015
Merged

Nik Molnar (nikmd23) merged 1 commit into
Glimpse:devfrom
damienpontifex:post-content-append

Conversation

@damienpontifex

Copy link
Copy Markdown

Resolves #91 by appending html to post content rather than overwriting with setcontent

@avanderhoorn

Copy link
Copy Markdown
Member

Damien Pontifex (@damienpontifex) great pickup! In your test, I'm assuming that things work correct in both cases (where you do and don't have additional content)? As a note, we are looking at switching things so that we inject Glimpse scripts without razor dependency (see #77).

@damienpontifex

Copy link
Copy Markdown
Author

From my testing (adding local glimpse into src of my global.json file and testing on my project), Glimpse is still injected into PostContent for both cases: when it is the only one there and also when I'm injecting further additional content.

#77 looks like it might be a little way off, so I'd love to see this integrated into the current implementation so it doesn't effect users currently utilising the Razor/TagHelper approach.

@nikmd23

Copy link
Copy Markdown
Contributor

This looks like a no brainer to me. Thanks for finding and fixing the bug Damien Pontifex (@damienpontifex)!

Nik Molnar (nikmd23) added a commit that referenced this pull request Nov 30, 2015
Appending html to PostContent rather than set
@nikmd23
Nik Molnar (nikmd23) merged commit a3309f2 into Glimpse:dev Nov 30, 2015
@damienpontifex
Damien Pontifex (damienpontifex) deleted the post-content-append branch December 1, 2015 01:39
@avanderhoorn

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants