Migrate the channel watchers and channel and thread creators to the generated UserResponse - #6736
Merged
Merged
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
…ated UserResponse
gpunto
force-pushed
the
migrate/channel-users
branch
from
September 25, 2026 13:06
9928394 to
8552279
Compare
|
gpunto
marked this pull request as ready for review
September 25, 2026 13:49
gpunto
enabled auto-merge
September 25, 2026 13:51
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (17)
💤 Files with no reviewable changes (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe client removes the offset-and-limit draft query API. Channel and thread DTO user fields now use ChangesDraft Query API
UserResponse DTO and Parsing
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established from the reviewed changes; merge after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The changed user parsing preserves the existing domain data path, and no new security boundary or weakened control was established. Compatibility with less-complete server responses remains uncertain. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. I’m a rabbit with a parsing plan, Comment |
andremion
approved these changes
Sep 28, 2026
Contributor
|
🚀 Available in v7.13.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Parse the channel watchers and the channel and thread
created_bywith the generatedUserResponse, andkeep two user keys in
extraDatathat the generated user models had started dropping.Part of AND-1291
Implementation
watchers(channel response and channel), the channelcreated_byand the thread and thread-infocreated_byat the generatedUserResponse. The existingUserResponsemapper handles them.deleted_atandrevoke_tokens_issued_beforeinUser.extraDatafor everyUserResponse, asthe event user models already did. The generated model declares both, so they stopped reaching
extraDataon every path that moved to it, while the hand-written user DTO left them there.queryDraftMessages(offset, limit)API call and its request model. Nothing called it;drafts are queried through
queryDrafts.Notes
The mute response's
own_userstays on the hand-written DTO. The E2E mock server builds it withoutinvisibleand the unread counters, which the generatedOwnUserResponserequires.Testing
UserResponseParityTestparses the same user JSON through the hand-written DTO and the generated model andrequires the same
User, with a user carrying every optional field and custom data.Device-probed a channel and a thread created with a custom field set on the user: the channel
created_by, the watcher list and the threadcreated_byeach matched the same user read throughgetMessagefield by field, custom field included.Summary by CodeRabbit