Sitelet https://github.com/GetStream/stream-chat-android/pull/6675
Skip to content

Remove parser test fixtures that nothing references - #6675

Merged
gpunto merged 1 commit into
developfrom
chore/remove-dead-parser-fixtures
Sep 1, 2026
Merged

Remove parser test fixtures that nothing references#6675
gpunto merged 1 commit into
developfrom
chore/remove-dead-parser-fixtures

Conversation

@gpunto

@gpunto gpunto commented Aug 31, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Goal

Remove eight fixture objects in parser2/testdata that nothing references.

They were added by #6473 alongside the fixtures the fast event parsing path does use, but they describe types with no adapter in parser2/direct, and no such adapter has ever existed, so nothing could consume them. They have since drifted, still asserting invisible = false for nested users where the wire never sends the field.

Closes AND-1469

Implementation

  • Delete AnswerTestData, ChannelTestData, ChannelUserReadTestData, CommandTestData, ConfigTestData, MemberTestData, PushPreferenceTestData and VoteTestData.

Testing

  • No production code is touched and no test referenced any of the eight, so the client suite is unchanged.
  • DtoTestDataTest also has no references, being a test class the runner executes, and it names its fixtures explicitly. None of the removed objects appear there, so it keeps compiling and passing.

Summary by CodeRabbit

  • Tests
    • Removed obsolete parser test fixtures covering answers, channels, members, commands, configuration, push preferences, votes, and read states.
    • Cleaned up test resources for scenarios involving optional and required fields.

@gpunto gpunto added the pr:test Test-only changes label Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 6.11 MB 6.11 MB 0.00 MB 🟢
stream-chat-android-ui-components 11.42 MB 11.42 MB 0.00 MB 🟢
stream-chat-android-compose 12.90 MB 12.90 MB 0.00 MB 🟢

@sonarqubecloud

sonarqubecloud Bot commented Aug 31, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gpunto
gpunto marked this pull request as ready for review August 31, 2026 13:29
@gpunto
gpunto requested a review from a team as a code owner August 31, 2026 13:29
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fcfbde8d-81f1-4c68-ac28-629e985ddaba

📥 Commits

Reviewing files that changed from the base of the PR and between 7077610 and 1d197ba.

📒 Files selected for processing (8)
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/AnswerTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/ChannelTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/ChannelUserReadTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/CommandTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/ConfigTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/MemberTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/PushPreferenceTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/VoteTestData.kt
💤 Files with no reviewable changes (8)
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/MemberTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/VoteTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/ChannelUserReadTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/AnswerTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/PushPreferenceTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/CommandTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/ConfigTestData.kt
  • stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/ChannelTestData.kt

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The change deletes eight parser2 test fixture files. The removed fixtures contained JSON payloads and expected model objects for parser tests.

Changes

Cohort / File(s) Summary
Parser2 test fixtures
stream-chat-android-client/src/test/java/io/getstream/chat/android/client/parser2/testdata/*TestData.kt		 Deletes fixtures for answers, channels, channel reads, commands, configuration, members, push preferences, and votes, including expected parsed model instances and missing-field cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 1d197

This change removes unused test-only fixtures without changing production behavior; no actionable merge-blocking risk remains.

Poem

A rabbit found fixtures tucked away,
With JSON trails from night to day.
The test-data burrow now lies bare,
Eight little files no longer dwell there.
Parse the path with careful paws.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing unreferenced parser test fixtures.
Description check ✅ Passed The description includes the goal, implementation details, linked issue, and testing rationale. It identifies all eight deleted fixtures and explains why no production or referenced test changes are r…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the goal, implementation details, linked issue, and testing rationale. It identifies all eight deleted fixtures and explains why no production or referenced test changes are required.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-dead-parser-fixtures

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gpunto
gpunto enabled auto-merge August 31, 2026 15:51
@gpunto
gpunto added this pull request to the merge queue Sep 1, 2026
Merged via the queue into develop with commit 3c17861 Sep 1, 2026
20 of 21 checks passed
@gpunto
gpunto deleted the chore/remove-dead-parser-fixtures branch September 1, 2026 17:11
@stream-public-bot stream-public-bot added the released Included in a release label Sep 10, 2026
@stream-public-bot

stream-public-bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🚀 Available in v7.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andremion andremion andremion approved these changes

Assignees

No one assigned

Labels

pr:test Test-only changes released Included in a release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpunto @stream-public-bot @andremion