Conversation
nykwono
marked this pull request as ready for review
September 30, 2026 02:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As things are inevitably added and improved on within the scripting system for Polymod, things are bound to get messy for the codebase of some files (and debatably already have).
This PR doesn't necessarily add really anything new but instead tries to make all internal hscript-related files as clean as possible by:
This isn't done yet! Which is why this is a draft as well to get feedback from other contributors and maintainers if possible on their opinions on this before putting it for full review.
Small things this PR also has:
PolymodScriptClassis ALWAYS instantiated usingPolymodStaticClassReference.instantiate(this is a MUST because of how superclasses work now)