Sitelet https://github.com/FunkinCrew/polymod/pull/522
Skip to content

[CHORE/FEEDBACK WANTED] Cleanup polymod.hscript._internal - #522

Open
nykwono wants to merge 2 commits into
FunkinCrew:developfrom
nykwono:general-script-cleanup
Open

nykwono wants to merge 2 commits into
FunkinCrew:developfrom
nykwono:general-script-cleanup

Conversation

@nykwono

@nykwono nykwono commented Sep 29, 2026

Copy link
Copy Markdown

As things are inevitably added and improved on within the scripting system for Polymod, things are bound to get messy for the codebase of some files (and debatably already have).
This PR doesn't necessarily add really anything new but instead tries to make all internal hscript-related files as clean as possible by:

  • Staying consistent with the established codestyle of other files within the library.
  • Re-ordering functions and fields are appropiate to help with readability.
  • Adding documentation so it's easier for people to understand what their purpose is.

This isn't done yet! Which is why this is a draft as well to get feedback from other contributors and maintainers if possible on their opinions on this before putting it for full review.

Small things this PR also has:

  • Makes sure PolymodScriptClass is ALWAYS instantiated using PolymodStaticClassReference.instantiate (this is a MUST because of how superclasses work now)
  • Makes sure using functions cache of script enums are cleared when scripts are reloaded.

@nykwono
nykwono marked this pull request as ready for review September 30, 2026 02:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant