Sitelet https://github.com/Evernote/evernote-sdk-python/pull/41
Skip to content

Add function to return entire OAuth dictionary - #41

Merged
mattcarrollcode merged 1 commit into
Evernote:masterfrom
Instapaper:master
Jun 30, 2015
Merged

mattcarrollcode merged 1 commit into
Evernote:masterfrom
Instapaper:master

Conversation

@Donohue

@Donohue Donohue commented Jun 29, 2015

Copy link
Copy Markdown
Contributor

There are important parameters here like expiry date

Signed-off-by: Brian Donohue brian.donohue89@gmail.com

There are important parameters here like expiry date

Signed-off-by: Brian Donohue <brian.donohue89@gmail.com>
@Donohue

Donohue commented Jun 29, 2015

Copy link
Copy Markdown
Contributor Author

@matthewayne and @rekotan,

This is very much a hotfix to provide access to some parameters in the OAuth dictionary that are not returned by get_access_token. The important one for Instapaper was the edam_expires parameter so we could handle expiry emails for our users.

I think the correct approach would be to create a new type for the OAuth dictionary that includes instance variables for all of the fields returned.

Thanks,
Brian

mattcarrollcode pushed a commit that referenced this pull request Jun 30, 2015
Add function to return entire OAuth dictionary
@mattcarrollcode
mattcarrollcode merged commit 44d8485 into Evernote:master Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants