Improve typescript definitions by using generics - #294
Open
mrdrogdrog wants to merge 1 commit into
Open
mrdrogdrog wants to merge 1 commit into
mrdrogdrog wants to merge 1 commit into
Conversation
mrdrogdrog
force-pushed
the
master
branch
3 times, most recently
from
September 19, 2022 21:54
530822d to
74f16d9
Compare
mrdrogdrog
marked this pull request as draft
September 19, 2022 22:17
mrdrogdrog
force-pushed
the
master
branch
2 times, most recently
from
September 20, 2022 11:40
2506d9f to
efeca18
Compare
mrdrogdrog
marked this pull request as ready for review
September 20, 2022 11:40
|
Hi there, |
|
Is this PR similar to #293 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/andywer/typed-emitter I replaced the usage of
anywith generics to make the typescript definitions more type safe. I tried to keep the compatibility with the old types.You now can define a map of constrains between an event name and the value types which will be enforced by typescript.