py: add pyln-grpc-proto to PyPI publishing CI - #8999
Open
ThomsenDrake wants to merge 1 commit into
Open
ThomsenDrake wants to merge 1 commit into
ThomsenDrake wants to merge 1 commit into
Conversation
ThomsenDrake
force-pushed
the
feat/pyln-grpc-proto-publish-ci
branch
from
March 30, 2026 19:32
9349bed to
6f54133
Compare
madelinevibes
force-pushed
the
feat/pyln-grpc-proto-publish-ci
branch
from
June 15, 2026 05:18
de3681e to
c705f0f
Compare
Andezion
approved these changes
Jul 22, 2026
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
Was touching the generic update-pyln-version-% sed lines intentional, or an accidental side-effect of testing/editing? Since it's a no-op on this project's supported platforms, it's not blocking
| @echo "Updating contrib/pyln-$* to $(NEW_VERSION)" | ||
| @$(SED) -i.bak 's/^version = .*/version = "$(NEW_VERSION)"/' contrib/pyln-$*/pyproject.toml && rm contrib/pyln-$*/pyproject.toml.bak | ||
| @$(SED) -i.bak 's/^__version__ = .*/__version__ = "$(NEW_VERSION)"/' contrib/pyln-$*/pyln/$*/__init__.py && rm contrib/pyln-$*/pyln/$*/__init__.py.bak | ||
| @$(SED) -i.bak 's/^version = .*/version = "$(NEW_VERSION)"' contrib/pyln-$*/pyproject.toml && rm contrib/pyln-$*/pyproject.toml.bak |
Collaborator
There was a problem hiding this comment.
The Makefile diff does touch the pre-existing shared update-pyln-version-% recipe (used by client/proto/testing, not just the new grpc target) and drops the trailing / delimiter from both sed expressions
…7929) Add pyln-grpc-proto to the pypi.yml publish matrix and create a dedicated update-pyln-grpc-version Makefile target that handles the package's non-standard directory layout (pyln/grpc/ instead of pyln/grpc-proto/) and strips the v-prefix from version tags. Also syncs the stale __version__ in pyln/grpc/__init__.py to match pyproject.toml. Changelog-None
Andezion
force-pushed
the
feat/pyln-grpc-proto-publish-ci
branch
from
July 22, 2026 23:06
c705f0f to
db27e76
Compare
Collaborator
|
hi @ThomsenDrake are you able to respond to @Andezion 's review comments?? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nFixes #7929 — Add
pyln-grpc-prototo the PyPI publishing workflow so the package is automatically published on release.\n\nChangelog-None\n\n### Changes\n\n1..github/workflows/pypi.yml— Addedpyln-grpc-prototo the publish matrix (same pattern aspyln-client,pyln-proto,pyln-testing)\n\n2.Makefile— Added a dedicatedupdate-pyln-grpc-versiontarget that handles the versioning differences:\n - Directory layout:pyln/grpc/instead ofpyln/grpc-proto/\n - Version format: PyPI uses25.09(novprefix), while the tag isv25.09\n\n3.contrib/pyln-grpc-proto/pyln/grpc/__init__.py— Synced stale__version__from"0.1.1"to"25.09"to matchpyproject.toml\n\n### Why a custom Makefile target?\n\nThe existingupdate-pyln-version-%pattern assumes:\n- Directory layout:contrib/pyln-<name>/pyln/<name>/__init__.py\n- Version passed verbatim fromgit describe\n\npyln-grpc-protobreaks both assumptions:\n- Usescontrib/pyln-grpc-proto/pyln/grpc/__init__.py\n- Needs thevprefix stripped for PyPI\n\nThe custom target is the minimal approach — it follows the exact same `` pattern as the generic targets and integrates intoupdate-pyln-versionsas a dependency.