Repository navigation
Bug fix in feature set split method - #731
Merged
Merged
Conversation
tamarl08
requested review from
Frost45,
damien2012eng,
desilinguist,
mulhod and
slava92
May 22, 2023 15:51
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 95.16% 95.24% +0.08%
==========================================
Files 29 29
Lines 3451 3449 -2
==========================================
+ Hits 3284 3285 +1
+ Misses 167 164 -3
☔ View full report in Codecov by Sentry. |
desilinguist
requested changes
May 22, 2023
desilinguist
left a comment
Collaborator
There was a problem hiding this comment.
Just a couple of minor tweaks. Looks great! Thank you for adding the comprehensive tests!!
Frost45
approved these changes
May 23, 2023
desilinguist
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split_by_idstosplitand edit docstring to explicitly say that the split is done on indices and not id valuesThis PR closes #727.