Repository navigation
Rename log output option to logs - #670
Merged
Merged
Conversation
- Modify configuration parser to allow 'logs' field. - Show a deprecation warning if the user uses 'log' instead of 'logs'. - Update all of the examples configuration files to use 'logs'. - Update all tests in `test_input.py` to use 'logs'. - Add a new test in `test_input.py`. - Update the tutorial and the documentation.
log output option to logs.log output option to logs
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
=======================================
Coverage 96.76% 96.76%
=======================================
Files 63 63
Lines 9077 9098 +21
=======================================
+ Hits 8783 8804 +21
Misses 294 294
Continue to review full report at Codecov.
|
- This is necessary for the new test to pass.
desilinguist
marked this pull request as ready for review
February 23, 2021 22:53
aoifecahill
approved these changes
Feb 24, 2021
mulhod
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #520.
log.test_input.pyto use 'logs'.test_input.py.