Repository navigation
Simplify parameter grids - #619
Merged
Merged
Conversation
desilinguist
requested review from
a user,
Lguyogiro,
aoifecahill,
farigys and
mulhod
June 5, 2020 13:59
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 91.71% 95.15% +3.43%
==========================================
Files 26 26
Lines 3031 3031
==========================================
+ Hits 2780 2884 +104
+ Misses 251 147 -104
Continue to review full report at Codecov.
|
ghost
reviewed
Jun 5, 2020
ghost
left a comment
There was a problem hiding this comment.
It looks good. Can we also have a test case with empty dictionary parameter grid.
mulhod
approved these changes
Jun 5, 2020
Collaborator
Author
|
Almost all of our tests in |
ghost
approved these changes
Jun 5, 2020
aoifecahill
approved these changes
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #618.