Repository navigation
Do not update dependencies when installing several dependencies at once - #92
Merged
Conversation
lacostej
reviewed
Nov 6, 2019
| { | ||
| Debug.Log("update " + pr.Package.PackageName); | ||
| UpdatePackage(pr, updateLockfile: updateLockfile); | ||
| UpdatePackage(pr, updateDependencies: false, updateLockfile: updateLockfile); |
Member
There was a problem hiding this comment.
So this wasn't a regression from #88.
Any chance we can have a unit test for this?
Member
Author
There was a problem hiding this comment.
Looks like it wasn't.
Any chance we can have a unit test for this?
On it.
Member
Author
There was a problem hiding this comment.
Turns out that's going to be super complicated to test. The package wasn't installed in the end, so the unit test would need to make sure that InstallPackage is not called with the problematic version, but we don't have clean separation of concerns which makes it hard to mock or inject.
lacostej
approved these changes
Nov 7, 2019
lacostej
left a comment
Member
There was a problem hiding this comment.
OK for the lack of test. Thanks for trying!
niezbop
deleted the
fix/uplift_manager/do_not_check_dependencies_when_installing_several_packages
branch
November 7, 2019 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
UpliftManager.InstallPackages(), several (solved) packages are solved at once and then passed for installation. However if the package already exist, it updates it to the expected version.The issue is that this update then try to update the package dependencies in cascade, updating packages which shouldn't be.