Repository navigation
Debug/add a log handler - #84
Merged
Merged
Conversation
lacostej
reviewed
May 25, 2019
lacostej
reviewed
May 25, 2019
lacostej
reviewed
May 25, 2019
niezbop
reviewed
May 27, 2019
niezbop
left a comment
Member
There was a problem hiding this comment.
Minor modifications, but otherwise looks ok!
|
|
||
| public class LogHandler : IDisposable | ||
| { | ||
| public bool ShowStackTrace = false; |
Member
There was a problem hiding this comment.
naming: showStackTrace! camelCasing. Same for the following vars
| InstallPackages(targets); | ||
| using (LogHandler LH = new LogHandler(appendToCurrentLogFile: true, showStackTrace: false)) | ||
| { | ||
| Debug.Log("> Install Dependenies with strategy " + strategy); |
lacostej
self-requested a review
May 27, 2019 13:34
lacostej
approved these changes
May 27, 2019
lacostej
reviewed
May 29, 2019
|
|
||
| bool updateLockfile = (strategy != InstallStrategy.ONLY_LOCKFILE); | ||
| InstallPackages(targets, updateLockfile); | ||
| bool updateLockfile = (strategy != InstallStrategy.ONLY_LOCKFILE); |
Member
There was a problem hiding this comment.
weird indentation in this file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at creating a Log handler for uplift. It dumps
UnityEngine.Debug.Logconsole logs messages to anuplift.logfile in order to make Uplift debugging easier.