Repository navigation
Correct update package function to prevent error in First method - #70
Merged
lacostej merged 3 commits intoMay 20, 2019
Merged
Conversation
scassard
force-pushed
the
fix/proper_UpdatePackage_function
branch
from
May 14, 2019 14:22
e5e7c00 to
6d473e5
Compare
Member
|
Great if you can explain why this is happening in the first place. Tip: look at the internal commit guidelines :) WRT to the issue I wonder if the solution is to avoid passing a null DependencyDefinition and do something similar to uplift/Assets/Plugins/Editor/Uplift/UpliftManager.cs Lines 424 to 426 in b367b96 |
Contributor
Author
|
I've just updated my first comment to explain clearly why this was happening and how I fixed it. |
…nition while installing
…ment in UpdatePackage
scassard
force-pushed
the
fix/proper_UpdatePackage_function
branch
from
May 20, 2019 15:00
72a2009 to
c895db1
Compare
lacostej
approved these changes
May 20, 2019
niezbop
approved these changes
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error happening sometimes when updating package :
System.InvalidOperationException: Operation is not valid due to the current state of the objectIt seemed to occurred when uplift tries to update a package which is not listed in the "UPFILE DEPENDENCIES" listed in Upfile.lock. Thus the search for the package definition failed.
Small fix which solve problem while updating a package was to set the package definition to null in that case by using
FirstOrDefaultinstead ofFirstmethod.NOTE : This PR depends on this PR
I had a little trouble opening this pull request, but it should be fine by now.