Repository navigation
Menu Items: Make installation from menu clearer - #60
Conversation
A lot of feedback tend to show that there was a confusion regarding what was doing what between "Debug/Install from lockfile" and "Install Dependencies". This moves the lockfile installation out of the debug section as it is not a debug-only feature and is used quite frequently. Moreover, this clarifies the messages to better explain the difference between the installation methods.
|
By moving it first aren't we modifying the default user behavior? See also
for reference |
|
We are not really modifying the default user behaviour actually, at least not the way it is currently in use right now. "Install Dependencies" tries to update all dependencies, regardless of the fact that they were changed in the Upfile or not. Therefore, the comparison with the Bundler is short lived, as we do not have the conservative update type behaviour. The behaviour promoted by "Install Dependencies" is the "bundle update" which is not what we want. Currently we should fix the dependency solving mechanism before anything to be able to put forward the correct behaviours, but this require a bit of time to implement it. Edit: We are not really modifying the default user behaviour because most people do not use "Install Dependencies", as it has side effects that they do not want, and resort to "Install from Lockfile" + update window. Therefore, we make it more straight forward and easier to understand. |
| } | ||
|
|
||
| [MenuItem("Tools/Uplift/Install Dependencies", false, 2)] | ||
| [MenuItem("Tools/Uplift/Install and upgrade dependencies", false, 3)] |
|
|
||
| [MenuItem("Tools/Uplift/Install Dependencies", false, 2)] | ||
| [MenuItem("Tools/Uplift/Install and upgrade dependencies", false, 3)] | ||
| private static void InstallDependencies() |
| } | ||
|
|
||
|
|
||
| [MenuItem("Tools/Uplift/Install exact dependencies", false, 2)] |
There was a problem hiding this comment.
It throws!
else if(strategy == InstallStrategy.ONLY_LOCKFILE)
{
if(!present)
throw new ApplicationException("Uplift cannot install dependencies in strategy ONLY_LOCKFILE if there is no lockfile");
targets = LoadLockfile().installableDependencies;
}
A lot of feedback tend to show that there was a confusion regarding what was doing what between "Debug/Install from lockfile" and "Install Dependencies". This moves the lockfile installation out of the debug section as it is not a debug-only feature and is used quite frequently.
Moreover, this clarifies the messages to better explain the difference between the installation methods.