Repository navigation
Fix upfile not refreshed before install - #39
Conversation
|
Not really happy with committing this without understanding how that would fix the problem. The only explanation I have is if this indeed changes the behavior is that named parameters are sort of ignored with the compiler we use. |
|
That's not an issue with the named parameters, but an issue with the singleton nature of the UpliftManager and the way public static void ResetInstances()
{
instance = null;
Upfile.ResetInstance();
Upbring.ResetInstance();
InitializeInstance();
}
internal static void InitializeInstance()
{
instance = new UpliftManager();
instance.upfile = Upfile.Instance();
}Because we have I removed the name parameter because it simply could not work in the current implementation of the UpliftManager, and therefore had no point of being in the code (for now). |
Fixes #38