[node] Update worker_threads module - #48424

@Semigradsky Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 48424,
  "author": "Semigradsky",
  "owners": [
    "Microsoft",
    "DefinitelyTyped",
    "jkomyno",
    "a-tarasyuk",
    "alvis",
    "r3nya",
    "btoueg",
    "brunoscheufler",
    "smac89",
    "touffy",
    "DeividasBakanas",
    "eyqs",
    "Flarna",
    "Hannes-Magnusson-CK",
    "KSXGitHub",
    "hoo29",
    "kjin",
    "ajafff",
    "islishude",
    "mwiktorczyk",
    "mohsen1",
    "n-e",
    "galkin",
    "parambirs",
    "eps1lon",
    "SimonSchick",
    "ThomasdenH",
    "WilcoBakker",
    "wwwy3y3",
    "samuela",
    "kuehlein",
    "j-oliveras",
    "bhongy",
    "chyzwar",
    "trivikr",
    "nguymin4",
    "yoursunny",
    "qwelias",
    "ExE-Boss",
    "Ryan-Willpower",
    "peterblazejewicz",
    "addaleax",
    "JasonHK",
    "victorperin"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "c7d8417",
  "headCommitOid": "c7d8417010c6c85d84c7c6e872d5f62e2937ff1b",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-06T08:13:48.000Z",
  "lastCommentDate": "2020-10-09T06:32:50.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48424/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "newPackages": [],
  "packages": [
    "node"
  ],
  "files": [
    {
      "path": "types/node/test/worker_threads.ts",
      "kind": "test",
      "package": "node"
    },
    {
      "path": "types/node/v12/worker_threads.d.ts",
      "kind": "definition",
      "package": "node"
    },
    {
      "path": "types/node/v13/worker_threads.d.ts",
      "kind": "definition",
      "package": "node"
    },
    {
      "path": "types/node/worker_threads.d.ts",
      "kind": "definition",
      "package": "node"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-08T20:01:21.000Z",
  "reviewersWithStaleReviews": [
    {
      "reviewedAbbrOid": "fd2ee11",
      "reviewer": "a-tarasyuk",
      "date": "2020-10-06T06:12:28Z"
    }
  ],
  "approvalFlags": 6,
  "isChangesRequested": false
}

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

node/v*

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

node/v*

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

node/v*

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

The TransferListItem type should be also added to the v12 types, but only containing:

type TransferListItem = ArrayBuffer | MessagePort;

@Semigradsky The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@Flarna Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@a-tarasyuk, @rbuckton, @ExE-Boss Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@a-tarasyuk, @rbuckton Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@Semigradsky Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @a-tarasyuk, @alvis, @r3nya, @btoueg, @BrunoScheufler, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Flarna, @Hannes-Magnusson-CK, @KSXGitHub, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @j-oliveras, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @ExE-Boss, @Ryan-Willpower, @peterblazejewicz, @addaleax, @JasonHK, @victorperin: you can do this too.)

@a-tarasyuk Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Ready to merge

I just published @types/node@14.11.8 to npm.

I just published @types/node@13.13.25 to npm.

I just published @types/node@12.12.67 to npm.