Copy azimuthal-average m=0 modes by remaining group keys - #337
Open
shaneraphel wants to merge 1 commit into
Open
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
Sphere and spherical averages assigned m=0 with a boolean mask. When M_max < L_max the local m=0 occupancy disagrees and NumPy raises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334
SphereAzimuthalAverageandSphericalAzimuthalAveragecopym = 0withcomp_out[m0_out] = comp_in[m0_in]. WhenM_max < L_maxthe input and output layouts have different local m=0 occupancy, so NumPy boolean assignment raises (96into64in the report).The current is the mask-length copy. This change copies
m = 0by the remaining group coordinates fromlocal_group_arrayson both domains.PolarAzimuthalAverage.radial_matrixis not rewritten.On unequal local masks the current raises; this change copies the overlapping groups. On equal masks this change matches current.