pull request after stashing - #45
Merged
Merged
Conversation
kbuffardi
reviewed
May 14, 2017
|
|
||
| **Minor** | ||
|
|
||
| * [I had added documentation for setting up react environment on ubuntu machine](That link is no longer in the repo) |
Contributor
There was a problem hiding this comment.
Do you have your old pull request for it? Or if it is part of the wiki, it should be discoverable by going to the wiki history
Contributor
Author
There was a problem hiding this comment.
It was part of wiki. I did not do documentation as a pull request. Let me check their wiki history..
Contributor
Author
There was a problem hiding this comment.
They have changed their entire wiki page, That's why it is not visible.
What can be used to trace back their old wiki page?
Contributor
|
If you go back to the wiki page, copy the URL provided by the "Clone Wiki"
and clone it locally. Then, within the local repo, look through the git log
and just provide me with a link to the wiki along with the commit hash of
your edit.
//Kevin
…On Sun, May 14, 2017 at 1:13 PM, Jayesh Tambe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In project/README.md
<#45 (comment)>
:
> @@ -14,6 +14,16 @@
## React
+[Jayesh Tambe](https://github.com/jtambe)
+
+**Major**
+
+* [Developed example code for DOM manipulation using react](react/react#9683)
+
+**Minor**
+
+* [I had added documentation for setting up react environment on ubuntu machine](That link is no longer in the repo)
They have changed their entire wiki page, That's why it is not visible.
What can be used to trace back their old wiki page?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH8FOk0Zg5Jtdz00ILmowe9BMeA9D9hTks5r52BVgaJpZM4NafMI>
.
|
Contributor
Author
|
Ok.. I found those commit hashes.. Are they visible to you in this pull request? |
Contributor
|
Looks good, just add a link to the wiki and I'll merge it.
//Kevin
…On Sun, May 14, 2017 at 1:44 PM, Jayesh Tambe ***@***.***> wrote:
Ok.. I found those commit hashes.. Are they visible to you in this pull
request?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH8FOtl1l1KcLRtuu9iFqhUsftZ7sbuqks5r52eWgaJpZM4NafMI>
.
|
Contributor
Author
|
Ok. Added FB react's wiki link in my section of readme.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git added project/readme.md