Prevent Windows agent console flashes - #27
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes Windows child-process spawning behind a CREATE_NO_WINDOW constructor to prevent transient console windows (“console flashes”) when the GUI-subsystem binary launches console helpers, and strengthens regression coverage by asserting against the console subsystem directly.
Changes:
- Added a Windows-only
hidden_windows_command()helper that appliesCREATE_NO_WINDOWin one place. - Updated Windows helper call sites (
tasklist,taskkill,cmd) to use the hidden-process constructor. - Strengthened/added Windows regression tests to validate “no console” via
GetConsoleWindow().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main.rs | Adds hidden_windows_command() and a Windows regression test; updates Windows helper spawns to use CREATE_NO_WINDOW. |
| crates/aibo-tools/src/shell.rs | Updates the Windows PowerShell regression test to query GetConsoleWindow() instead of MainWindowHandle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CREATE_NO_WINDOWValidation
cargo test --bin aibo --lockedcargo test -p aibo-tools --lockedcargo fmt --allgit diff --check