Fix Windows screenshot and selected-text capture - #24
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
Shortcut strings for the Windows region-capture binding are inconsistent with the app’s hotkey label formatting, causing UI/docs mismatch.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR improves Windows context/screenshot capture by snapshotting the source app before the aibo panel can take focus, and by exposing the existing native region-capture action in the UI and docs.
Changes:
- Thread an optional
AppReffocus snapshot throughUiRequest::CaptureContextinto the runtime capture pipeline. - Keep the Windows panel non-activating during context capture, then focus the composer once capture completes/fails.
- Show region-capture shortcuts in the attachment/help overlays and update the README shortcut table.
File summaries
| File | Description |
|---|---|
| src/main.rs | Runtime capture now accepts an optional AppRef snapshot to avoid mis-attributing context after focus changes. |
| README.md | Documents Windows region-capture chord alongside the macOS binding. |
| crates/aibo-ui/src/panel.rs | Shows region-capture action in attach/help overlays on platforms that support it. |
| crates/aibo-ui/src/bridge.rs | Extends UiRequest::CaptureContext to carry the optional AppRef. |
| crates/aibo-ui/src/app.rs | Adds non-activating Windows summon flow and preserves focus snapshot across selection-driven fresh starts. |
| crates/aibo-platform/src/macos/mod.rs | Adds a synchronous frontmost-app snapshot helper used pre-presentation. |
| crates/aibo-platform/src/lib.rs | Exposes cross-platform focused_app_ref() for the UI to snapshot focus cheaply before presenting. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Comment on lines
+2764
to
+2767
| #[cfg(target_os = "windows")] | ||
| { | ||
| Some("Ctrl+Shift+Alt+Space") | ||
| } |
| |---|---| | ||
| | `⌥Space` | Summon / dismiss the panel (Windows: `Ctrl+Shift+Space`) | | ||
| | `⌥⇧Space` | Crop a screen region and open it as an attachment (macOS) | | ||
| | `⌥⇧Space` | Crop a screen region and open it as an attachment (Windows: `Ctrl+Shift+Alt+Space`) | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification