Notices in the panel; fix the dev release publish - #12
Merged
Merged
Conversation
A toast rendered its severity bar with Length::Fill, and a cross-axis Fill claims every point the parent can spare — so one sentence became a box the height of the whole window with the text stranded at the bottom (owner screenshot). The bar is a fixed 18 pt now. More to the point, the toast floated *over* the conversation, outside the layout, where it could not be sized against what it covered. It is now an ordinary row on the rail directly above the composer (owner: 'can we just show it in the chat window?'), and it costs height like every other row.
The dev release started failing the same HTTP 403 the version tags did: --target is refused for GITHUB_TOKEN whatever contents: write says (cli/cli#9514). dev needs its tag moved to the built commit, so move it the way the checkout's own credentials already allow — git tag -f plus a push — and let the release attach to a tag that is already correct. The push cannot re-trigger this workflow: it fires on v* and this tag is 'dev'.
There was a problem hiding this comment.
Pull request overview
This PR fixes two UI issues with notices/toasts in the panel (incorrect sizing and overlay behavior) and adjusts the GitHub Actions release workflow to avoid a gh release create --target path that can 403 with GITHUB_TOKEN, especially for the rolling dev release.
Changes:
- Make the toast severity bar fixed-height (instead of
Length::Fill) to avoid full-window-height toasts. - Render notices as a normal railed row inside the panel layout directly above the composer, and account for that row in panel height estimation.
- For
devreleases, move thedevtag viagit tag -f+ force-push before creating the release (and remove--targetusage entirely).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/aibo-ui/src/widgets.rs |
Fixes toast severity bar sizing by using a fixed height instead of Length::Fill. |
crates/aibo-ui/src/panel.rs |
Moves toast into the panel rail above the composer and updates height estimation to include the notice row. |
.github/workflows/release.yml |
Avoids --target and recuts/pushes the dev tag via git before creating the release to prevent 403s. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3289
to
+3292
| /// Fixed so a streaming run never resizes the window (§16's reserve rule). | ||
| /// One notice row above the composer: bar-and-text plus the toast's own | ||
| /// padding and the column's spacing. | ||
| const NOTICE_ROW_HEIGHT: f32 = 52.0; |
Comment on lines
+1479
to
+1485
| // A notice is now a row in the panel rather than a floating box, so | ||
| // it costs height like every other row. | ||
| let notice = if self.toast.is_some() { | ||
| NOTICE_ROW_HEIGHT | ||
| } else { | ||
| 0.0 | ||
| }; |
No pre-commit hook existed, and a bare `cargo clippy` disagrees with the one CI runs: locally `missing_docs` is a warning and the command exits 0, while CI adds `-D warnings` and fails. That gap turned a missing doc comment into a red build twice today. .githooks/pre-commit mirrors the CI invocation exactly (fmt, then clippy with -D warnings); .githooks/pre-push runs the tests, kept separate so commits stay cheap. Install with `git config core.hooksPath .githooks`, documented in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the owner's screenshot.
The toast was the size of the window. Its severity bar used
Length::Fill, and a cross-axis Fill claims every point the parent can spare — one sentence rendered as a full-height box with the text stranded at the bottom. Fixed bar height now.And it floated over the conversation. Being outside the layout, it covered content and could not be sized against it. Per the owner's ruling ("can we just show it in the chat window?") a notice is now an ordinary row on the rail directly above the composer, and it costs panel height like every other row.
The dev release 403'd again. The earlier fix removed
--targetonly for version tags;devstill passed it and hit the same GITHUB_TOKEN refusal (cli/cli#9514).devgenuinely needs its tag moved to the built commit, so it now moves withgit tag -f+ push — which the checkout's credentials already permit — and the release attaches to a tag that is already correct. No workflow loop: the trigger isv*.