Check NoArchiveError when sending block notifications - #214
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
HerbertJordan
previously approved these changes
May 5, 2025
HerbertJordan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks!
HerbertJordan
approved these changes
May 5, 2025
jenikd
added a commit
that referenced
this pull request
May 6, 2025
wsodsong
pushed a commit
that referenced
this pull request
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes situation, when there is no archive database for checking current block height when sending subscribers block notification
Related to https://github.com/0xsoniclabs/sonic-admin/issues/175