Sitelet https://github.com/phpredis//phpredis/commit/daa4d9f
Skip to content

Commit daa4d9f

Browse files
Sean-DerSean-Der
committed
Zero out stack allocated zvals before using them, protected against unexpected behavior
1 parent bd15fab commit daa4d9f

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

‎redis.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3099,6 +3099,7 @@ redis_build_eval_cmd(RedisSock *redis_sock, char **ret, char *keyword,
30993099
char *key, *old_cmd;
31003100
int key_free;
31013101
size_t key_len;
3102+
ZVAL_UNDEF(&z_tmp);
31023103

31033104
if(Z_TYPE_P(elem) == IS_STRING) {
31043105
key = Z_STRVAL_P(elem);

‎redis_commands.c‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1919,6 +1919,7 @@ int redis_pfcount_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
19191919
size_t key_len;
19201920
char *key;
19211921
short kslot=-1;
1922+
ZVAL_UNDEF(&z_tmp);
19221923

19231924
if(zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,"z",&z_keys)==FAILURE) {
19241925
return FAILURE;

0 commit comments

Comments
 (0)