Python: Update .expected to support Python 3.12
#14791
Open
+291
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You might wonder why the number of lines changed, but it's due to `tty` module receiving its' first update since 2001, so the actual number of lines DID change :phew: https://github.com/python/cpython/commits/3.12/Lib/tty.py Since there is now a difference between Python 2 and Python 3, we need to restrict the lines of code test to only run as Python 3.
…ic directory This moves the tests to Python 2, next we copy them to Python 3.
9687594
to
4256fbf
Compare
Was removed in 3.11, see https://docs.python.org/3.10/library/asyncio-task.html#asyncio.coroutine I couldn't make the __awwait__ actually give the result to the agen function... I also tried looking into https://docs.python.org/3/library/types.html#types.coroutine, but also failed to make that work. Without the Future, such as doing `yield SOURCE` inside `__await__` it complains `RuntimeError: Task got bad yield: 'source'`
270b9ef
to
0f1dc9b
Compare
I reckon this is due to the Python 3 version used by the Python 2 tests is different from 3.12, so even with --lang=3 the tests are still using an incompatible version :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You might wonder why the number of lines changed, but it's due to
ttymodule receiving its' first update since 2001, so the actual number of lines DID change :phew:https://github.com/python/cpython/commits/3.12/Lib/tty.py