Sitelet https://web.archive.org/web/20240815075541/https://github.com/python/cpython/issues/121474
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barrier hangs indefinitely when arg parties < 0 or invalid type #121474

Closed
pygeek opened this issue Jul 8, 2024 · 3 comments
Closed

Barrier hangs indefinitely when arg parties < 0 or invalid type #121474

pygeek opened this issue Jul 8, 2024 · 3 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@pygeek
Copy link
Contributor

pygeek commented Jul 8, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

threading.Barrier at no point checks for valid parties. parties, of a negative value, or invalid type hang indefinitely on .wait(). This behavior is inconsistent from the behavior of any other threading primitives, which either conduct sanity checks on args during initialization, or fail at some point in their execution.

Steps to reproduce:

from threading import Barrier
# negative
barrier = Barrier(-1) # <threading.Barrier at 0x10aa789b0: waiters=0/-1>
barrier.wait()

# invalid type string
barrier = Barrier("test") # <threading.Barrier at 0x10ae64980: waiters=0/test>
barrier.wait()

# invalid type float
barrier = Barrier(0.5) # <threading.Barrier at 0x10aa7a570: waiters=0/0.5>
barrier.wait()

# invalid type object
barrier = Barrier(object()) # <threading.Barrier at 0x10ae4f500: waiters=0/<object object at 0x10a878730>>
barrier.wait()

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Linked PRs
@pygeek pygeek added the type-bug An unexpected behavior, bug, or error label Jul 8, 2024
@pygeek pygeek changed the title Barrier hangs indefinitely when arg parties < 0 Barrier hangs indefinitely when arg parties < 0 or invalid type Jul 8, 2024
pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Added Barrier parties sanity chack.
46e209c
pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Added test.
422b259
@graingert
Copy link
Contributor

graingert commented Jul 8, 2024 •
edited
Loading

asyncio.Barrier has this validation https://github.com/python/cpython/blob/3.12/Lib/asyncio/locks.py#L457

@pygeek
Copy link
Contributor Author

pygeek commented Jul 8, 2024 •
edited
Loading

https://github.com/python/cpython/blob/3.12/Lib/asyncio/locks.py#L457

This issue is not related to async.Barrier. This is a bug in threading.Barrier

https://github.com/python/cpython/blob/3.12/Lib/threading.py#L670

@graingert
Copy link
Contributor

graingert commented Jul 8, 2024 •
edited
Loading

https://github.com/python/cpython/blob/3.12/Lib/asyncio/locks.py#L457

This issue is not related to async.Barrier. This is a bug in threading.Barrier

https://github.com/python/cpython/blob/3.12/Lib/threading.py#L670

I'm aware. My point is that asyncio.Barrier has this validation so threading.Barrier should have it also

pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Fixed sanity check.
cc1d74e
pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Added Barrier parties sanity chack.
860437d
@bedevere-app bedevere-app bot mentioned this issue Jul 8, 2024
Merged
pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Add blurb.
546dbe6
pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Add threading.Barrier parties arg sanity chack.
6b38cab
pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Add threading.Barrier parties arg sanity check.
6878079
pygeek added a commit to pygeek/cpython that referenced this issue Jul 8, 2024
@pygeek
pythongh-121474: Add threading.Barrier parties arg sanity check.
58880e2
pygeek added a commit to pygeek/cpython that referenced this issue Jul 10, 2024
@pygeek
pythongh-121474: Add threading.Barrier parties arg sanity check.
644d89b
serhiy-storchaka pushed a commit that referenced this issue Jul 30, 2024
@pygeek
gh-121474: Add threading.Barrier parties arg sanity check. (GH-121480)
d27a53f
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 30, 2024
@pygeek @miss-islington
pythongh-121474: Add threading.Barrier parties arg sanity check. (pyt…
4212392 
…honGH-121480)

(cherry picked from commit d27a53f)

Co-authored-by: Clinton <pygeek@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 30, 2024
@pygeek @miss-islington
pythongh-121474: Add threading.Barrier parties arg sanity check. (pyt…
f7c7070 
…honGH-121480)

(cherry picked from commit d27a53f)

Co-authored-by: Clinton <pygeek@users.noreply.github.com>
This was referenced Jul 30, 2024
Merged
Merged
serhiy-storchaka pushed a commit that referenced this issue Jul 30, 2024
@miss-islington @pygeek
[3.12] gh-121474: Add threading.Barrier parties arg sanity check. (GH…
ca22750 
…-121480) (GH-122443)

(cherry picked from commit d27a53f)

Co-authored-by: Clinton <pygeek@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this issue Jul 30, 2024
@miss-islington @pygeek
[3.13] gh-121474: Add threading.Barrier parties arg sanity check. (GH…
202cfbf 
…-121480) (GH-122444)

(cherry picked from commit d27a53f)

Co-authored-by: Clinton <pygeek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pygeek @graingert @serhiy-storchaka