Sitelet https://web.archive.org/web/20240111011618/https://github.com/github/codeql/pull/15265
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: add .def to exceptions to AV rule 32 #15265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

C++: add .def to exceptions to AV rule 32 #15265

wants to merge 3 commits into from
+9 −3

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Jan 9, 2024

This is used as textual includes in several projects for macro metaprogramming, for example in llvm-project and in swift (and since some time in our internal codebase as well).

@redsun82
C++: add .def to exceptions to AV rule 32
270df94 
This is used as textual includes in several projects for macro
metaprogramming, for example in `llvm-project` and in `swift` (and since
some time in our internal codebase as well).
@redsun82 redsun82 requested a review from a team as a code owner January 9, 2024 14:20
@github-actions github-actions bot added the C++ label Jan 9, 2024
@redsun82 redsun82 force-pushed the redsun82/def-to-non-header-include-exceptions branch from fea8bd9 to 27160b8 Compare January 9, 2024 14:31
MathiasVP
MathiasVP approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we have a successful DCA run!

@redsun82
Copy link
Contributor Author

redsun82 commented Jan 10, 2024 •
edited

LGTM once we have a successful DCA run!

Do you know which DCA query suite contains this query?

@redsun82
Copy link
Contributor Author

LGTM once we have a successful DCA run!

Do you know which DCA query suite contains this query?

silly me, I can just manually select this one query :)

@jketema
Copy link
Contributor

jketema commented Jan 10, 2024

Isn't the query just in the nightly suite?

@MathiasVP
Copy link
Contributor

Isn't the query just in the nightly suite?

It should be, yes. You can check by running codeql resolve queries path-to-the-nightly-suite (and when I run it the query does indeed appear on the list).

@redsun82
Copy link
Contributor Author

still it's ok to manually select the query if the PR only affects that one query, right?

@jketema
Copy link
Contributor

jketema commented Jan 10, 2024

Preferably you'll run the nightly suite, as that'll show whether there are any adverse consequences due to your change and the way queries interact (I expect this to be pretty boring here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@redsun82 @jketema @MathiasVP