Add a Dockerfile and GitHub Actions script #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll test this as soon as I return from vacation by next week. Until then, everyone interested may build the image from your branch. |
hellt
reviewed
Jan 6, 2024
Comment on lines
+42
to
+43
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3.0.0 |
There was a problem hiding this comment.
shall we add setup-qemu-action as mentioned in the docker docs?
https://docs.docker.com/build/ci/github-actions/multi-platform/
There was a problem hiding this comment.
This builds perfectly fine without qemu so I don't see the need for it.
hellt
reviewed
Jan 6, 2024
hellt
reviewed
Jan 6, 2024
|
For some reason the workflow does not run on v4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows someone to manually build the Docker image or just use the prebuilt one (built with GitHub Actions).
Fix #18
Note: In order for the Docker image to be pullable, another release will have to be made so a new tag is created.