Sitelet https://web.archive.org/web/20240106194436/https://github.com/github/codeql/pull/15243
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Fix upgrade delete directives #15243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ruby: Fix upgrade delete directives #15243

wants to merge 1 commit into from
+170 −0

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Jan 5, 2024

This PR adds missing delete directives in upgrade and downgrade scripts.

@github-actions github-actions bot added the Ruby label Jan 5, 2024
@cklin cklin marked this pull request as ready for review January 5, 2024 22:29
@cklin cklin requested a review from a team as a code owner January 5, 2024 22:29
aibaars
aibaars approved these changes Jan 6, 2024
View reviewed changes
ruby/ql/lib/upgrades/40be81bc2086eb0368f33c770e0a84817bb340c3/upgrade.properties
argument_list_def.rel: delete
array_child.rel: delete
array_def.rel: delete
assignment_def.rel: delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cklin @aibaars