Sitelet https://web.archive.org/web/20260504002645/https://github.com/angular/angular-cli/pull/25044
Skip to content

feat(@schematics/angular): add --pure to ng generate pipe#25044

Closed
5im0n wants to merge 1 commit intoangular:mainfrom
5im0n:feat/add-pure-option-generate-pipe
Closed

feat(@schematics/angular): add --pure to ng generate pipe#25044
5im0n wants to merge 1 commit intoangular:mainfrom
5im0n:feat/add-pure-option-generate-pipe

Conversation

@5im0n
Copy link
Copy Markdown

@5im0n 5im0n commented Apr 20, 2023

Adds the --pure flag when generating pipe through ng generate pipe.

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Before this update, it was impossible to generate pure pipe with the ng generate pipe command

Issue Number: N/A

What is the new behavior?

User can now generate pure pipe directly with CLI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Apr 20, 2023
@5im0n 5im0n force-pushed the feat/add-pure-option-generate-pipe branch from 140bcba to 2f987d8 Compare April 20, 2023 10:56
Adds the `--pure` flag when generating pipe through `ng generate pipe`.
@5im0n 5im0n force-pushed the feat/add-pure-option-generate-pipe branch from 2f987d8 to a81a3fb Compare April 20, 2023 10:58
@alan-agius4 alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Aug 29, 2023
@alan-agius4 alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label Oct 11, 2023
@alan-agius4
Copy link
Copy Markdown
Collaborator

@5im0n, thanks for your contribution.

Adding pure: true is a trivial that IMHO it does not require a command line option.

Let's re-consider this again in the future if there is a greater desire for this option from the community.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants