Sitelet https://web.archive.org/web/20230609093442/https://github.com/ionic-team/ionic-framework/pull/26960
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test-apps): set minimum node version to 16 #26960

Merged
merged 2 commits into from Mar 15, 2023
Merged

chore(test-apps): set minimum node version to 16 #26960

merged 2 commits into from Mar 15, 2023

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Test app infra and min node version for workspace

What is the current behavior?

Internally we noted that running the test apps and workspace with node v12 causes issues.

Issue URL: N/A

What is the new behavior?

  • Requires that local development uses node v16 or higher

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codeflowapp
Copy link

codeflowapp bot commented Mar 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package labels Mar 14, 2023
@sean-perkins sean-perkins marked this pull request as ready for review March 14, 2023 19:53
@sean-perkins sean-perkins requested a review from a team as a code owner March 14, 2023 19:53
liamdebeasi
liamdebeasi reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set this on the project package.json files too? angular, core, etc

@sean-perkins
Copy link
Contributor Author

@liamdebeasi I left them off potentially distributed package.json files for now, as they will produce a warning in any package that installs those packages as a dependency.

@liamdebeasi
Copy link
Member

Ahh ok makes sense. Thanks!

@sean-perkins sean-perkins merged commit c17d1d8 into main Mar 15, 2023
43 checks passed
@sean-perkins sean-perkins deleted the chore/test-app-node-version branch March 15, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sean-perkins @liamdebeasi @brandyscarney