Ruby: change evaluation order of destructured assignments#12540
Merged
Conversation
a208919 to
bb6cc3b
Compare
hvitved
previously approved these changes
Mar 21, 2023
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Looks correct to me. Let's do a DCA run before merging.
hvitved
requested changes
Mar 22, 2023
Contributor
hvitved
left a comment
There was a problem hiding this comment.
One minor comment, otherwise LGTM. We should also do another DCA run.
| } | ||
| } | ||
|
|
||
| private class LhsScopedConstant extends LhsWithReceiver, TScopeResolutionConstantAccess { |
Contributor
There was a problem hiding this comment.
I think it would be better to move the existing (private) ScopeResolutionConstantAccess class into internal/Constant.qll, and then reference that here.
hvitved
requested changes
Mar 23, 2023
006ff98 to
c4a98ff
Compare
hvitved
previously approved these changes
Mar 24, 2023
c4a98ff to
5ebf308
Compare
5ebf308 to
3b12ddf
Compare
hvitved
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.