build: avoid unnecessary re-evaluation of starlark code #49106
Closed
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The experimental allow tags propagation flag is a `BuildLanguage` option and causes all Starlark code to be re-invoked. This causes a slow-down when switching between bazel query/ bazel build because the option is not set for `bazel query`. We fix it by applying the option to all commands, using `common`.
|
This PR was merged into the repository by commit 2a4d987. |
alxhub
pushed a commit
that referenced
this pull request
Feb 16, 2023
The experimental allow tags propagation flag is a `BuildLanguage` option and causes all Starlark code to be re-invoked. This causes a slow-down when switching between bazel query/ bazel build because the option is not set for `bazel query`. We fix it by applying the option to all commands, using `common`. PR Close #49106
alxhub
pushed a commit
that referenced
this pull request
Feb 16, 2023
The experimental allow tags propagation flag is a `BuildLanguage` option and causes all Starlark code to be re-invoked. This causes a slow-down when switching between bazel query/ bazel build because the option is not set for `bazel query`. We fix it by applying the option to all commands, using `common`. PR Close #49106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The experimental allow tags propagation flag is a
BuildLanguageoption and causes all Starlarkcode to be re-invoked. This causes a slow-down when switching between bazel query/ bazel
build because the option is not set for
bazel query.We fix it by applying the option to all commands, using
common.