C#/Java: Move the modelgenerator. - #11760
Conversation
|
It is expected that the Models as Data - Diff workflows fails at it is not compatible with moving around the related scripts. |
|
DCA looks good. |
aeisenberg
left a comment
There was a problem hiding this comment.
LGTM from the CLI and CI side. Reviews from at least one of the language teams would be good as well.
It looks like the CI failures are due to flaky network requests. And please be sure to notify relevant people regarding query id changes (which I think you have).
Thank you for the review! |
atorralba
left a comment
There was a problem hiding this comment.
Java looks plausible to me.
cb0a166
1beb95a to
cb0a166
Compare
|
I had to do a rebase, which didn't cause any real changes. |
sidshank
left a comment
There was a problem hiding this comment.
LGTM. I spent some time looking for import paths or directories constructed using string concatenation, that might have been missed, but found nothing.
cb0a166 to
11ca3f4
Compare
|
@atorralba or @tamasvajk : Sorry to bother you again, but I needed to rebase once more (was not able to merge yesterday due to issues with actions timeout). There are no changes since last time. Could one of you please rubber stamp the PR again? |
It turns out that we might need to reference some of the libraries and queries in the model generator directory, which is not possible when the directory name contains a dash.
In this PR we remove the dash from the model generator directory name and also adjust workflows, query names and tags accordingly.
A separate PR for DCA is also needed.