Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Resolve conflicts in generated files. #41
Comments
|
@serhiy-storchaka Do you have an example of such PR? I usually look at documentation changes, so I'm not familiar with
Thanks :) |
|
and should this be done even when using |
|
The recent example: python/cpython#4118. For running |
|
We're running the webservice in heroku, and I don't think we can run |
|
I think https://github.com/heroku/heroku-buildpack-apt could work here. Then the issue may be limitations (time) on background jobs or one-off dynos or whatever is used to run configure. |
|
Time shouldn't be an issue. Backport jobs are all done in the worker dyno. |
|
But I don't know a thing about the buildpack in Heroku.. |
|
I’ve used that buildpack (in addition to the base Python buildpack), would be happy to discuss setting it up! |
|
perhaps even a custom merge driver could be written for this? (at least, specifically for the argument clinic files which is what I hit in python/cherry-picker#18) and then the various cherry-picking / etc. tooling can use that merge driver? |
For now the automated cherry-pick failed if generated files are changed. These conflicts can be resolved automatically — just regenerate files by running
make regen-all(or with more specific targets, depending on affected files).