Sitelet https://web.archive.org/web/20210703105724/https://github.com/python/cpython/pull/26980
Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44490: Add __parameters__ and __getitem__ to types.Union #26980

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

bpo-44490: Add __parameters__ and __getitem__ to types.Union #26980

wants to merge 10 commits into from
+97 −19

Conversation

@uriyyo
Copy link
Contributor

@uriyyo uriyyo commented Jul 1, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44490
@uriyyo
bpo-44490: Add __parameters__ to types.Union
4f8ef47
@uriyyo
Copy link
Contributor Author

@uriyyo uriyyo commented Jul 1, 2021

@Fidget-Spinner Could you please review this PR?
@uriyyo
Add Py_LIMITED_API to genericaliasobject
c4ee98e
@Fidget-Spinner
Fidget-Spinner approved these changes Jul 1, 2021
View changes
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner left a comment

@uriyyo thank you for sending this PR so quickly! Excellent work. I only have a few minor readability nits below.
Lib/test/test_types.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Core and Builtins/2021-07-01-11-59-34.bpo-44490.xY80VR.rst Outdated Show resolved Hide resolved
Objects/unionobject.c Outdated Show resolved Hide resolved
Include/genericaliasobject.h Outdated Show resolved Hide resolved
uriyyo and others added 6 commits Jul 1, 2021
@uriyyo @Fidget-Spinner
Update Lib/test/test_types.py
fceac5f 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@uriyyo @Fidget-Spinner
Update Misc/NEWS.d/next/Core and Builtins/2021-07-01-11-59-34.bpo-44490…
39a7aab 
….xY80VR.rst

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@uriyyo @Fidget-Spinner
Update Objects/unionobject.c
3444b8c 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@uriyyo @Fidget-Spinner
Update Include/genericaliasobject.h
543f6db 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@uriyyo
Update genericaliasobject.c
b87d59b
@uriyyo
Update unionobject.c
3d96784
@Fidget-Spinner Fidget-Spinner requested a review from gvanrossum Jul 1, 2021
@Fidget-Spinner
Fidget-Spinner reviewed Jul 1, 2021
View changes
Lib/test/test_types.py Show resolved Hide resolved
uriyyo and others added 2 commits Jul 1, 2021
@uriyyo @Fidget-Spinner
Update Lib/test/test_types.py
0ad654c 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@uriyyo
Update test_types.py
cddb7e0
@uriyyo
Copy link
Contributor Author

@uriyyo uriyyo commented Jul 2, 2021

@Fidget-Spinner Thanks for review, I have added tests that you suggested.
@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented Jul 2, 2021

@Fidget-Spinner Thanks for review, I have added tests that you suggested.

Thanks for applying the suggestions. This LGTM. I've requested a review from Guido and I'm waiting for him to take a look when he has the time. I can't merge PRs, sorry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed awaiting core review
Projects
None yet
Milestone
No milestone
4 participants
@uriyyo @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot