gh-99714: asyncio - add shield_scope context manager and shielded decorator#99899
Closed
whatamithinking wants to merge 5 commits into
Closed
gh-99714: asyncio - add shield_scope context manager and shielded decorator#99899whatamithinking wants to merge 5 commits into
whatamithinking wants to merge 5 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
gvanrossum
reviewed
Jan 20, 2023
Comment on lines
+81
to
+82
| shield = object() # just for making sure shields closed in order | ||
| # if __enter__ and __exit__ called directly |
Member
There was a problem hiding this comment.
But who would do that? Let them suffer. Task().shields can just be an integer counter.
gvanrossum
reviewed
Jan 20, 2023
Comment on lines
+94
to
+101
| def shielded(func): | ||
| """Decorator to shield the call of a async function or method, | ||
| wrapping it in a shield_scope().""" | ||
| @functools.wraps(func) | ||
| async def _shielded(*args, **kwargs): | ||
| with shield_scope(): | ||
| return await func(*args, **kwargs) | ||
| return _shielded |
Member
There was a problem hiding this comment.
Do we absolutely, truly need two ways to do it (a decorator and a context manager)? I'd start with just the context manager.
gvanrossum
reviewed
Jan 20, 2023
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Would this require any updates to/for TaskGroup?
Member
|
It looks like there isn't enough interest to pursue this. Closing. (Respond on the issue if you disagree.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#99714