Sitelet https://web.archive.org/web/20221223122310/https://github.com/python/cpython/pull/99819
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fnmatch docs: link to fnmatch.filter(), not builtins.filter() #99819

Merged
merged 1 commit into from Nov 28, 2022
Merged

fnmatch docs: link to fnmatch.filter(), not builtins.filter() #99819

merged 1 commit into from Nov 28, 2022

Conversation

matthewhughes934
Copy link
Contributor

@matthewhughes934 matthewhughes934 commented Nov 27, 2022

Fix a link that was pointing to the builtin filter instead of fnmatch.filter

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 27, 2022
@matthewhughes934
Fixup filter link in fnmatch docs
2de58cd 
Fix a link that was pointing to the builtin `filter` instead of
`fnmatch.filter`
slateny
slateny approved these changes Nov 28, 2022
View changes
Copy link
Contributor

@slateny slateny left a comment

lgtm as it matches L45's .filter which links correctly

@kumaraditya303 kumaraditya303 requested a review from AlexWaygood Nov 28, 2022
AlexWaygood
AlexWaygood approved these changes Nov 28, 2022
View changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Thanks!

@AlexWaygood AlexWaygood changed the title Fixup filter link in fnmatch docs fnmatch docs: link to fnmatch.filter(), not builtins.filter() Nov 28, 2022
@AlexWaygood AlexWaygood merged commit ca3e611 into python:main Nov 28, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 28, 2022

Thanks @matthewhughes934 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 28, 2022

GH-99849 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2022
@matthewhughes934 @miss-islington
fnmatch docs: link to fnmatch.filter(), not builtins.filter() (p…
5ec5fc6 
…ythonGH-99819)

(cherry picked from commit ca3e611)

Co-authored-by: Matthew Hughes <34972397+matthewhughes934@users.noreply.github.com>
@AlexWaygood
Copy link
Member

AlexWaygood commented Nov 28, 2022

The bug only exists in the main and 3.11 branches.

miss-islington added a commit that referenced this pull request Nov 28, 2022
@miss-islington @matthewhughes934
fnmatch docs: link to fnmatch.filter(), not builtins.filter() (G…
a2b84bb 
…H-99819)

(cherry picked from commit ca3e611)

Co-authored-by: Matthew Hughes <34972397+matthewhughes934@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slateny slateny

@AlexWaygood AlexWaygood

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewhughes934 @miss-islington @bedevere-bot @AlexWaygood @slateny