Sitelet https://web.archive.org/web/20221223145520/https://github.com/python/cpython/pull/100065
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100050: Fix an assertion error when raising unclosed parenthesis errors in the tokenizer #100065

Merged
merged 1 commit into from Dec 6, 2022
Merged

gh-100050: Fix an assertion error when raising unclosed parenthesis errors in the tokenizer #100065

merged 1 commit into from Dec 6, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 6, 2022 •
edited by miss-islington

@pablogsal pablogsal requested a review from lysnikolaou as a code owner Dec 6, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 6, 2022
Closed
@netlify
Copy link

netlify bot commented Dec 6, 2022 •
edited

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 06a7d9e
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/638fc26b85a0db0009161afa

@pablogsal
pythongh-100050: Fix an assertion error when raising unclosed parenth…
06a7d9e 
…esis errors in the tokenizer

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 6, 2022
lysnikolaou
lysnikolaou approved these changes Dec 6, 2022
View changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

LGTM!

@miss-islington miss-islington merged commit 97e7004 into python:main Dec 6, 2022
20 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Dec 6, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2022
@pablogsal @miss-islington
pythongh-100050: Fix an assertion error when raising unclosed parenth…
6a6ee5a 
…esis errors in the tokenizer (pythonGH-100065)

(cherry picked from commit 97e7004)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Automerge-Triggered-By: GH:pablogsal
@miss-islington
Copy link
Contributor

miss-islington commented Dec 6, 2022

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 97e7004cfe48305bcd642c653b406dc7470e196d 3.10

@miss-islington miss-islington self-assigned this Dec 6, 2022
@bedevere-bot
Copy link

bedevere-bot commented Dec 6, 2022

GH-100067 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this pull request Dec 7, 2022
@miss-islington @pablogsal
gh-100050: Fix an assertion error when raising unclosed parenthesis e…
2b97ddd 
…rrors in the tokenizer (GH-100065)

(cherry picked from commit 97e7004)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Automerge-Triggered-By: GH:pablogsal
pablogsal added a commit to pablogsal/cpython that referenced this pull request Dec 7, 2022
@pablogsal
[3.10] pythongh-100050: Fix an assertion error when raising unclosed …
5a69f95 
…parenthesis errors in the tokenizer (pythonGH-100065)

Automerge-Triggered-By: GH:pablogsal.
(cherry picked from commit 97e7004)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 7, 2022

GH-100073 is a backport of this pull request to the 3.10 branch.

pablogsal added a commit that referenced this pull request Dec 7, 2022
@pablogsal
[3.10] gh-100050: Fix an assertion error when raising unclosed parent…
72cfe5b 
…hesis errors in the tokenizer (GH-100065) (#100073)

Automerge-Triggered-By: GH:pablogsal.
(cherry picked from commit 97e7004)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou

Assignees

@miss-islington miss-islington

Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @miss-islington @bedevere-bot @lysnikolaou