Sitelet https://web.archive.org/web/20221223123028/https://github.com/python/cpython/issues/87547
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add small test for frozen module line number table #87547

Closed
nascheme opened this issue Mar 3, 2021 · 2 comments
Closed

add small test for frozen module line number table #87547

nascheme opened this issue Mar 3, 2021 · 2 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@nascheme
Copy link
Member

nascheme commented Mar 3, 2021

BPO 43381
Nosy @nascheme
PRs
  • bpo-43381: Add frozen module co_lines() test #24712
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2021-03-03.00:52:30.007>
labels = ['type-feature', 'tests']
title = 'add small test for frozen module line number table'
updated_at = <Date 2021-03-03.01:01:59.365>
user = 'https://github.com/nascheme'

    bugs.python.org fields:

    activity = <Date 2021-03-03.01:01:59.365>
actor = 'nascheme'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2021-03-03.00:52:30.007>
creator = 'nascheme'
dependencies = []
files = []
hgrepos = []
issue_num = 43381
keywords = ['patch']
message_count = 1.0
messages = ['387989']
nosy_count = 1.0
nosy_names = ['nascheme']
pr_nums = ['24712']
priority = 'low'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43381'
versions = []
    @nascheme
    Copy link
    Member Author

    nascheme commented Mar 3, 2021

    In bug bpo-43372, we didn't notice that the code for the __hello__ module was not re-generated. Things seems to be okay but the line number table was corrupted. It seems a good idea to add a small test to ensure that doesn't happen again.

    I marked the test as CPython implementation specific.

    @nascheme nascheme added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Mar 3, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @nascheme
    Copy link
    Member Author

    nascheme commented Nov 28, 2022

    Tests have been added as part of gh-28664, closing.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @nascheme