This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Support includes#85
Closed
hendrikvanantwerpen wants to merge 5 commits intomainfrom
Closed
Conversation
8a5388d to
e00b0b9
Compare
Contributor
Author
|
Closing as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support adding includes on the command line.
Solution
Includes are specified as paths to files. This may be too limited to generate faithful stack graphs for those files, since package name and source root information cannot be specified. See discussion in https://github.com/github/semantic-code/issues/301.
Includes are expected to be source files in the target language, which will be parsed and processed using the language's TSG file to get the corresponding stack graph.
Implementation
To prevent reading, parsing, and generating the stack graph for includes for every test, a mechanism is added to cache file results in the
StackGraphLanguage.