Sitelet https://web.archive.org/web/20221230002559/https://github.com/nodejs/node/pull/45913
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add release host var to promotion script #45913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: add release host var to promotion script #45913

wants to merge 1 commit into from
+11 −1

Conversation

ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Dec 19, 2022 •
edited

Adds a NODEJS_RELEASE_HOST environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release.

cc @nodejs/releasers

@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 19, 2022 •
edited by ruyadorno

Review requested:

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 19, 2022
mscdex
mscdex reviewed Dec 19, 2022
View changes
doc/contributing/releases.md Outdated Show resolved Hide resolved
@ruyadorno ruyadorno force-pushed the add-host-env-var-to-release-script branch 2 times, most recently from 8d30d64 to 4fcdf24 Compare Dec 19, 2022
@ruyadorno ruyadorno added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 20, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48641/

lpinca
lpinca reviewed Dec 20, 2022
View changes
doc/contributing/releases.md Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Dec 21, 2022
Open
12 tasks
@github-actions github-actions bot mentioned this pull request Dec 22, 2022
Open
14 tasks
@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 22, 2022
@github-actions github-actions bot mentioned this pull request Dec 23, 2022
Open
13 tasks
aduh95
aduh95 reviewed Dec 28, 2022
View changes
tools/release.sh Outdated Show resolved Hide resolved
@ruyadorno
tools: add release host var to promotion script
9ce6067 
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers
to provide a custom proxy host to connect to when performing the
promotion steps of a given release.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
@ruyadorno ruyadorno force-pushed the add-host-env-var-to-release-script branch from 4fcdf24 to 9ce6067 Compare Dec 29, 2022
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Dec 29, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48755/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex

@lpinca lpinca

@aduh95 aduh95

@jasnell jasnell

@aymen94 aymen94

@RafaelGSS RafaelGSS

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ruyadorno @nodejs-github-bot @mscdex @jasnell @lpinca @aymen94 @aduh95 @RafaelGSS