Parse Python 3.9+ parenthesized context managers #4329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Since the upstream grammar for this is not LR(1), we abuse LALRPOP macros and the Into/TryInto traits to build a cover grammar that converts to either tuples or `with` items after additional validation. It’s annoying and ugly, but something like this is basically our only option short of switching to a more powerful parser algorithm. Fixes RustPython#4145. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
6375425 to
b7f4ff7
Compare
youknowone
approved these changes
Dec 12, 2022
|
Amazing work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the upstream grammar for this is not LR(1), we abuse LALRPOP macros and the
Into/TryIntotraits to build a cover grammar that converts to either tuples orwithitems after additional validation. It’s annoying and ugly, but something like this is basically our only option short of switching to a more powerful parser algorithm.Fixes #4145.
(Cc @charliermarsh, who I know is working on a more powerful parser algorithm in astral-sh/ruff#286. But this may be a useful stopgap.)