Rb: use instanceof instead of extends on DataFlow::CallNode in some case#11397
Merged
erik-krogh merged 2 commits intogithub:mainfrom Nov 23, 2022
Merged
Rb: use instanceof instead of extends on DataFlow::CallNode in some case#11397erik-krogh merged 2 commits intogithub:mainfrom
instanceof instead of extends on DataFlow::CallNode in some case#11397erik-krogh merged 2 commits intogithub:mainfrom
Conversation
hvitved
approved these changes
Nov 23, 2022
Contributor
hvitved
left a comment
There was a problem hiding this comment.
LGTM. Let's do a DCA run before merging.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed an
override DataFlow::Node getAnArgumentin classes thatextends DataFlow::CallNode.That is just a foot-gun waiting to happen if
DataFlow::CallNodegets angetAnArgumentpredicate, so I changed those classes toinstanceof DataFlow::CallNode.Drive-by cleanup of imports in
Open3.qllbased on feedback from QL-for-QL.