C++: Fix flow out of const member functions #11314

MathiasVP · 2022-11-16T22:49:49Z

This implements #5196, but for IR-based use-use dataflow library. The motivation for this "hack" is to get flow in the following example (which I've taken from our library tests):

class C_const_member_function {
  char* data_;
public:
  char* data() const { return data_; }
};

void test_with_const_member(char* source) {
  C_const_member_function c;
  memcpy(c.data(), source, 16);
  sink(c.data()); // $ ast,ir
}

and apparently, this was also the missing flow for some of the smart pointer tests 🎉.

…of-const-member-functions

C++: Fix flow out of const member functions.

b12955e

MathiasVP requested a review from a team as a code owner Nov 16, 2022

github-actions bot added the C++ label Nov 16, 2022

MathiasVP added the no-change-note-required This PR does not need a change note label Nov 16, 2022

Merge branch 'replace-ast-with-ir-use-usedataflow' into fix-flow-out-…

b9bcff4

…of-const-member-functions

C++: Fix flow out of const member functions #11314

Are you sure you want to change the base?

C++: Fix flow out of const member functions #11314

Conversation

MathiasVP commented Nov 16, 2022