Sitelet https://web.archive.org/web/20221116005120/https://github.com/github/codeql/pull/11276
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL: add 'False positive' issue template #11276

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Nov 15, 2022

No description provided.


<!--
1. Open the project on GitHub.com.
2. Switch to the `Security` tab. For example, https://lgtm.com/projects/g/pallets/click/alerts/.
Copy link
Contributor

@igfoo igfoo Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this URL should be updated to a code-scanning URL

Copy link
Contributor Author

@aibaars aibaars Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I removed that URL. Such URLs are inaccessible for others, so a real example would just be a dead link for most viewers.

.github/ISSUE_TEMPLATE/ql--false-positive.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ql--false-positive.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ql--false-positive.md Outdated Show resolved Hide resolved
Co-authored-by: Pierre <turbo@github.com>
about: Report CodeQL alerts that you think should not have been detected (not applicable, not exploitable, etc.)
title: False positive
labels: false-positive
assignees: ''
Copy link
Contributor

@aeisenberg aeisenberg Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to assign this to the first responder automatically? @github/codeql-first-responder

Copy link
Collaborator

@adityasharad adityasharad Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that will work - we can't assign teams to issues, only individuals. If we put the handle in the issue template body, the issue creator would need to be a member of our org to actually notify a team in our org.

Copy link
Contributor

@aeisenberg aeisenberg Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah...didn't know that. I am happy with this template, though. @turbo should probably approve since he had some suggestions earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants