Sitelet https://web.archive.org/web/20221223145651/https://github.com/python/cpython/pull/17219
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bpo-38811: Check for presence of os.link method in pathlib" #17219

Merged
merged 1 commit into from Nov 18, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 18, 2019 •

@vstinner
Copy link
Member Author

vstinner commented Nov 18, 2019

The PR #17170 broke buildbot https://buildbot.python.org/all/#/builders/40/builds/3413 and it was merged whereas the CLA was not signed.

@vstinner vstinner requested a review from serhiy-storchaka Nov 18, 2019
@tohojo
Copy link
Contributor

tohojo commented Nov 18, 2019

So that means you'd rather I open a completely new pull request with the buildbot failure fixed, instead of a fix on top of current master?

@vstinner vstinner merged commit 59c8088 into master Nov 18, 2019
@vstinner vstinner deleted the revert-17170-bpo-38811 branch Nov 18, 2019
@bedevere-bot
Copy link

bedevere-bot commented Nov 18, 2019

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner
Copy link
Member Author

vstinner commented Nov 18, 2019

So that means you'd rather I open a completely new pull request with the buildbot failure fixed, instead of a fix on top of current master?

First of all, please sign the CLA: see the bot's explanation.
#17170 (comment)

I merged my revert, so in short you have to rewrite PR #17170. If possible, with a fix for the Windows 7 buildbot. By default, if a change breaks a buildbot and nobody fix the issue quickly, the change should be reverted.
https://pythondev.readthedocs.io/ci.html#revert-on-fail

Here, it was also a licensing issue.

@tohojo
Copy link
Contributor

tohojo commented Nov 18, 2019

@vstinner
Copy link
Member Author

vstinner commented Nov 18, 2019

Is there a way to get the buildbot to run on the PR before it's merged?
All the CI tests passed beforehand, and I don't have a Windows system to
test on myself...

Ping me once you're ready. I can help you on that. There is a way to run buildbots on a PR before it's merged. And I have a Windows 10 VM. But I don't think that I will be able to reproduce the issue on my Windows 10 VM.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants