sqlite3: Replace Py_BuildValue with faster APIs #93829

erlend-aasland · 2022-06-15T07:50:42Z

cpython/Modules/_sqlite/microprotocols.c

Lines 83 to 87 in 274769c

    
           /* look for an adapter in the registry */ 
        
           key = Py_BuildValue("(OO)", (PyObject*)Py_TYPE(obj), proto); 
        
           if (!key) { 
        
               return NULL; 
        
           }

Can use faster PyTuple_Pack.

cpython/Modules/_sqlite/microprotocols.c

Lines 60 to 63 in 274769c

    
           key = Py_BuildValue("(OO)", (PyObject*)type, proto); 
        
           if (!key) { 
        
               return -1; 
        
           }

Can use faster PyTuple_Pack.

cpython/Modules/_sqlite/connection.c

Lines 1585 to 1587 in 274769c

    
           } else { 
        
               return Py_BuildValue("i", sqlite3_total_changes(self->db)); 
        
           }

Can use PyLong_FromLong.

The text was updated successfully, but these errors were encountered:

- In Modules/_sqlite/connection.c, use PyLong_FromLong - In Modules/_sqlite/microprotocols.c, use PyTuple_Pack

erlend-aasland linked a pull request Jun 15, 2022 that will close this issue

gh-93829: In sqlite3, replace Py_BuildValue with faster APIs #93830

Merged

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 15, 2022

pythongh-93829: In sqlite3, replace Py_BuildValue with faster APIs

bf38cec

erlend-aasland closed this as completed in #93830 Jun 15, 2022

erlend-aasland added a commit that referenced this issue Jun 15, 2022

gh-93829: In sqlite3, replace Py_BuildValue with faster APIs (#93830)

4e9fa71

- In Modules/_sqlite/connection.c, use PyLong_FromLong - In Modules/_sqlite/microprotocols.c, use PyTuple_Pack

sqlite3: Replace Py_BuildValue with faster APIs #93829

sqlite3: Replace Py_BuildValue with faster APIs #93829

Comments

erlend-aasland commented Jun 15, 2022