Sitelet https://web.archive.org/web/20260609085046/https://github.com/github/codeql/pull/9971
Skip to content

C++: Handle all forms of constant attribute arguments#9971

Merged
jketema merged 8 commits into
github:mainfrom
jketema:attribute-arg
Aug 11, 2022
Merged

C++: Handle all forms of constant attribute arguments#9971
jketema merged 8 commits into
github:mainfrom
jketema:attribute-arg

Conversation

@jketema

@jketema jketema commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Aug 4, 2022
@github-actions github-actions Bot added the C++ label Aug 4, 2022
@jketema jketema force-pushed the attribute-arg branch 4 times, most recently from 1d96694 to 2b6a8a4 Compare August 9, 2022 10:03
@jketema jketema marked this pull request as ready for review August 10, 2022 05:58
@jketema jketema requested a review from a team as a code owner August 10, 2022 05:58

@MathiasVP MathiasVP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/**
* Gets the text for the value of this argument, if its value is
* a string or a number.
* a constant or token.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably write this as or a token, but I won't force you to do another submodule bump just for that. So let's just wait with that 😂.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jketema jketema merged commit a5c0fa2 into github:main Aug 11, 2022
@jketema jketema deleted the attribute-arg branch August 11, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants